Add shellcheck and pre-commit to CI jobs
#3002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terhorstd
added
T: Enhancement
heplesser
requested changes
Jun 20, 2024
| run: | | ||
| pip install pre-commit | ||
|
|
||
| - name: "Run shellcheck..." |
There was a problem hiding this comment.
Suggested change
| - name: "Run shellcheck..." | |
| - name: "Run pre-commit ..." |
| run: | | ||
| find . -iname "*.sh" | xargs shellcheck | ||
|
|
||
| pre-commit-hooks: |
There was a problem hiding this comment.
Check if this has already been integrated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an addendum to #2880 adding a
pre-commitrun also to the CI pre-build checks.The
shellcheckis also added separately to address language specific linters on the same level.Related PRs are:
clang-formatpre-commit hook #2936isortpre-commit to make in-place changes #2968