-
Notifications
You must be signed in to change notification settings - Fork 370
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge remote-tracking branch 'nest/master' into connection_semantics_…
…prototype_merge
- Loading branch information
Showing
471 changed files
with
1,624 additions
and
1,267 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
on: [push] | ||
|
||
jobs: | ||
trigger_externals: | ||
name: "Trigger downstream repos" | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Trigger nest/nest-extension-module CI | ||
uses: peter-evans/repository-dispatch@v2 | ||
with: | ||
token: ${{ secrets.NEST_EXTENSION_MODULE_TRIGGER_TOKEN }} | ||
repository: 'nest/nest-extension-module' | ||
event-type: dispatch-event_nest-update | ||
client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}"}' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
.. _connect_index: | ||
|
||
Connect NEST with other tools | ||
============================= | ||
|
||
|
||
.. toctree:: | ||
:maxdepth: 1 | ||
|
||
nest_server | ||
using_nest_with_music |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
doc/htmldoc/developer_space/guidelines/code_review_guidelines.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
.. _code_guidelines: | ||
|
||
Code review guidelines | ||
====================== | ||
|
||
Using our purely :ref:`pull-request-based workflow <git_workflow>`, | ||
code can be developed very flexibly by internal and external | ||
contributors. At the same time this workflow allows us to enforce | ||
stricter rules on code that ends up in the public repository. | ||
|
||
Following are rough guidelines for the code reviewers. These are not | ||
meant to prevent progress, but to keep up the code quality as the | ||
number of developers is growing. All of this is not set in stone and | ||
can be discussed on the :ref:`NEST mailing lists <contact_us>`. | ||
|
||
* In most cases, each pull request needs an OK from the | ||
CI platform and at least two reviewers to be merged. | ||
* The two reviews have to cover the technical side (i.e., if the code | ||
does the right thing and is architecturally sound) and the content | ||
side (i.e., if the code is scientifically correct and fixes an | ||
actual issue). | ||
* For changes labeled “not code” or “minor” (e.g., changes in | ||
documentation, fixes for typos, etc.), the need for a second code | ||
review can be waived, and a single review plus the OK from the CI | ||
system is sufficient to merge the request. | ||
* New features like SLI or PyNEST functions, neuron or synapse models | ||
need to be accompanied by one or more tests written in either SLI or | ||
Python. | ||
* Each change to the code has to be reflected in the | ||
corresponding examples and documentation. | ||
* A pull request should be coherent and contain only changes that | ||
belong together. | ||
* Please also check that the typesetting of the documentation looks | ||
correct. To learn how to test the documentation locally offline, | ||
please check out our :ref:`User documentation workflow | ||
<userdoc_workflow>`. | ||
|
||
|
||
Before merging, reviewers have to make sure that: | ||
|
||
1. pull request titles match the actual content of the PR and | ||
be adequate for the release notes | ||
1. pull request titles are complete sentences that start with an | ||
upper-case, present-tense verb and end without punctuation | ||
1. pull requests are assigned to projects and properly and completely | ||
labeled | ||
1. all discussions are settled and all conversations are marked as | ||
resolved | ||
1. there are no blocking issues mentioned in the comments |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 2 additions & 0 deletions
2
...rdoc/contribute/styleguide/sample_doc.rst → ...pace/guidelines/styleguide/sample_doc.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
:orphan: | ||
|
||
.. _sample_doc: | ||
|
||
Main title of document | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
.. _developer_space: | ||
|
||
Developer space | ||
=============== | ||
|
||
Here is all documentation pertaining to the development of NEST. | ||
It is documentation for anyone needing to touch the code or documentation. | ||
|
||
|
||
.. toctree:: | ||
:maxdepth: 1 | ||
:caption: Install from source | ||
|
||
../installation/linux_install | ||
|
||
.. toctree:: | ||
:maxdepth: 1 | ||
:caption: Workflows | ||
:glob: | ||
|
||
workflows/* | ||
|
||
|
||
.. toctree:: | ||
:maxdepth: 1 | ||
:caption: Guidelines | ||
:glob: | ||
|
||
guidelines/* | ||
guidelines/styleguide/styleguide | ||
guidelines/styleguide/vim_support_sli | ||
|
||
|
||
.. toctree:: | ||
:maxdepth: 1 | ||
:caption: Templates | ||
:glob: | ||
|
||
templates/* | ||
|
||
.. toctree:: | ||
:maxdepth: 1 | ||
:caption: SLI docs | ||
:glob: | ||
|
||
sli_docs/index | ||
|
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
.. _sli_doc: | ||
|
||
SLI documentation | ||
================= | ||
|
||
|
||
.. toctree:: | ||
:maxdepth: 1 | ||
|
||
an-introduction-to-sli | ||
first-steps | ||
neural-simulations | ||
objects-and-data-types | ||
programming-in-sli | ||
using-files-and-keyboard-input | ||
|
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.