-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splashscreen implemented #189
base: master
Are you sure you want to change the base?
Conversation
Good news @nerzhul, So i think this PR is safe to merge without breaking changes for the users :) |
@nerzhul any concerns about this PR? Can i provide more information or help you? |
pinging @nerzhul about this open PR ❤️ |
i'm not sure it's useful, app load very fast |
Do you see disadvantages? I think there are three reasons why this should be merged:
In short: you don't know in which environement your app will run. So if there are no disadvantages for you, but there mght be advantages fore others, why not? |
@nerzhul currently has not much time for the Nextcloud apps. Maybe @nerzhul you can add @stefan-niedermann as a maintainer to this repository/app? @stefan-niedermann It would be awesome if we could get the Nextcloud SMS app back on track again. Would you be interested in maintaining the client? |
I am currently very busy with the Notes and Deck android app, therefore i don't have much time unfortunately. |
I implemented a splashscreen like in Notes, News and (soon) Files app.
Attention: This will remove the launcher icon from home screens when the user updates the app (basically the activity changes).With the last commit i managed to keep the old launcher - for the user nothing will change :)I think it might be possible to keep the launchers on the homescreen, if we keep the names, but it will be weird in your code when yourGot some better inspiration by https://github.com/nextcloud/android/pull/2448/filesMainActivity
launches theSplashscreenActivity
and theRealMainActivity
launches theMainActivity
- that's why i implemented it clean ;-)