-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language rework #174
base: master
Are you sure you want to change the base?
Language rework #174
Conversation
src/main/res/values/strings.xml
Outdated
<string name="fix_permissions">Fix permissions</string> | ||
<string name="err_kitkat_required">Android 4.4 or greater is required to use this feature.</string> | ||
<string name="restore_finished">SMS restoration is now finished.</string> | ||
<string name="err_kitkat_required">Android 4.4 or above is required to use this feature.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't agree with above here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverting
<string name="pref_sync_others">Synchronize in other modes</string> | ||
<string name="title_activity_login">Sign in</string> | ||
|
||
<!-- Login --> | ||
<string name="prompt_login">Login</string> | ||
<string name="prompt_login">Log in</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry but i'm not in favor of this space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Login" is not a verb, whereas "Log in" is.
@@ -207,30 +207,30 @@ | |||
|
|||
<!-- Notifications --> | |||
<string name="sync_title">Sync process</string> | |||
<string name="sync_inprogress">Sync in progress...</string> | |||
<string name="fatal_error">Fatal error ! </string> | |||
<string name="sync_inprogress">Sync in progress …</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those ... are not supported on android if i remember
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ellipses are UTF-8. Works just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, while Android lint warns you to use the character code … instead :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, … is wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't say wrong, just not how Android wants it to be expressed. See e.g. http://www.mysamplecode.com/2012/05/android-replace-with-ellipsis-character.html?m=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that isn't in other Nextcloud Android resources, and it is very prone to errors in translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, you should also fix the en_US and en_GB files with the same fix ?
ping |
@nerzhul The other resources will be overwritten by the translation platform regardless. |
@nerzhul ACK |
As per https://en.wiktionary.org/wiki/SMSes
The "could not read your SMSes" should possibly be a singular (?)