-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace H256 with the one in rust-numext #15
Open
joii2020
wants to merge
16
commits into
nervosnetwork:master
Choose a base branch
from
joii2020:dev_rep_H256
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ff3ef11
Replace H256 with the one in rust-numext
joii2020 d3e48c3
Delete class H256 completely, use numext H256 instead.
joii2020 70c2fd2
Repair warning, delete two unused codes
joii2020 fcb8ac4
The last time the format was changed, the CI problem has been resolved
joii2020 dff1e56
Remove H256 from lib.rs and change it to SmtH256 to avoid confusion; …
joii2020 fc0a843
Revert "Remove H256 from lib.rs and change it to SmtH256 to avoid con…
joii2020 fbf439b
The struce H256 is marked as pub(crate) and fix CI
joii2020 79a677f
merge H256Ord to h256.rs to avoid code duplication
joii2020 02985a2
Replace several iter with into_iter,
joii2020 071c201
revert new_ckb_smt in smt.rs file _new_ckb_smt
joii2020 dd466f5
H256Ord use Deref to return H256
joii2020 e015964
Use a function to implement H256 sorting instead of using a class
joii2020 89b7e85
remove std in features
joii2020 da76840
Remove two unreasonable codes:
joii2020 103801e
Remove the "extern crate std" in test.rs
joii2020 018c5f3
Organize the code, remove some unnecessary code
joii2020 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to mark std as external crate