Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pending on #191] add invoice status and check logic in TLC #239

Open
wants to merge 5 commits into
base: yukang-more-on-payment-session
Choose a base branch
from

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Oct 17, 2024

  1. Add Ckb invoice status in db, and check invoice status in TLC ops
  2. Fix the wrong get_invoice status with payment session
  3. Add invoice cancel RPC

After #191 is merged, change this merge target branch to main.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.96610% with 85 lines in your changes missing coverage. Please review.

Project coverage is 44.37%. Comparing base (6930c31) to head (4d0e6a9).

Files with missing lines Patch % Lines
src/fiber/channel.rs 7.14% 39 Missing ⚠️
src/rpc/invoice.rs 0.00% 39 Missing ⚠️
src/invoice/invoice_impl.rs 12.50% 7 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##           yukang-more-on-payment-session     #239      +/-   ##
==================================================================
- Coverage                           44.41%   44.37%   -0.04%     
==================================================================
  Files                                  44       44              
  Lines                               27997    28093      +96     
==================================================================
+ Hits                                12435    12467      +32     
- Misses                              15562    15626      +64     
Flag Coverage Δ
unittests 44.37% <27.96%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants