Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE thrown from SecurityAmount.RoundedAmount #177

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Dec 11, 2023

When the struct is uninitialized, NRE can be thrown from the property. Granted, folks shouldn't be using uninitialized values.

When the struct is uninitialized, NRE can be thrown from the property. Granted, folks shouldn't be using uninitialized values.
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68a0705) 75.23% compared to head (a08b337) 75.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   75.23%   75.24%           
=======================================
  Files         155      155           
  Lines        9070     9072    +2     
  Branches      835      836    +1     
=======================================
+ Hits         6824     6826    +2     
  Misses       2045     2045           
  Partials      201      201           
Flag Coverage Δ
LinuxHost 75.24% <100.00%> (+<0.01%) ⬆️
Release 75.24% <100.00%> (+<0.01%) ⬆️
WindowsHost 75.24% <100.00%> (+<0.01%) ⬆️
macOSHost 75.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AArnott AArnott merged commit 49ae049 into main Dec 11, 2023
6 checks passed
@AArnott AArnott deleted the fixSecurityAmount branch December 11, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant