Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add means to retrieve more birthday height values #176

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Dec 10, 2023

  • Optimized birthday height: the block number on the first block that actually contains a transaction related to this account. A user may create a wallet at block height X, but only receive ZEC for the first time at X+Y, at that point, only X+Y is relevant as a birthday height for that account.
  • Rebirth height: The height of the first block that contains a transaction that provides unspent funds (whether as a shielded note or UTXO). This could be provided as a birthday height when importing the account in order to access the full balance of the account, but not necessary download its full history.

* Optimized birthday height: the block number on the first block that actually contains a transaction related to this account. A user may create a wallet at block height X, but only receive ZEC for the first time at X+Y, at that point, only X+Y is relevant as a birthday height for that account.
* Rebirth height: The height of the first block that contains a transaction that provides _unspent funds_ (whether as a shielded note or UTXO). This could be provided as a birthday height when importing the account in order to access the full balance of the account, but not necessary download its full history.
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (592417e) 75.46% compared to head (1f59fa8) 75.23%.

Files Patch % Lines
src/Nerdbank.Zcash/RustBindings/LightWallet.cs 0.00% 26 Missing ⚠️
src/Nerdbank.Zcash/LightWalletClient.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   75.46%   75.23%   -0.23%     
==========================================
  Files         155      155              
  Lines        9043     9070      +27     
  Branches      830      832       +2     
==========================================
  Hits         6824     6824              
- Misses       2018     2045      +27     
  Partials      201      201              
Flag Coverage Δ
LinuxHost 75.23% <0.00%> (?)
Release 75.23% <0.00%> (-0.23%) ⬇️
WindowsHost 75.23% <0.00%> (-0.23%) ⬇️
macOSHost 75.23% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AArnott AArnott merged commit 68a0705 into main Dec 10, 2023
4 of 6 checks passed
@AArnott AArnott deleted the rebirthHeightAPI branch December 10, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant