Place repositories (git/oci) behind the Repository interface and use a Factory to create instances of implementations #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nephio-prow
bot
assigned Catalin-Stratulat-Ericsson, efiacor, JamesMcDermott, kispaljr and kushnaidu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing Porch code to make it easier to introduce a database cache.
It reinforces the structure of the code so that repository implementations (git/oci) are behind the interface and are only used by calling the interface. The
repoimplpackage is introduced as a package that contains "final" repository implementations. The following list details the refactors:pkg/repoimplpackage is introduced, this package contains a factory for creating implementations of theRepositorytype that store packages that are source or target packages for Porch (such as git and oci), that isRepositoryimplementations that are not Porch internal cachespkg/git' package is moved topkg/repoimpl/git`pkg/oci' package is moved topkg/repoimpl/oci`repoimplfactory are inpkg/repoimpl/types(to avoid circular imports)RepoImplFactoryinterface is introduced to create instances of repos (git or oci today)CreateRepoImplfunction inpkg/repoimpl/repoimpl.gocreates an instance of a repo based on the incoming configuration, calling the factory in either git or ociRepoImplOptionsstruct containing the options that theRepoImplimplementations use but the cache does not useCacheFactoryinterface is introduced for creating cache implementations, where the implementation of the cache is behind the factory interlaceCacheFactoryimplementation is added to the memory cache.