fix for #736 Implement missing Modify event on the porch Repo Custom Resource #167
Conversation
|
Hi Team, Based on the comments and changes here nephio-project/nephio#736 , I understand that we are not returning anything. Either way, I have raised an MR to address this by just returning it. I'm not entirely sure how effective this approach is, so I would appreciate it if you could review and share your feedback. |
| @@ -137,7 +137,7 @@ func (b *background) updateCache(ctx context.Context, event watch.EventType, rep | |||
| return b.cacheRepository(ctx, repository) | |||
| case watch.Modified: | |||
| klog.Infof("Repository modified: %s:%s", repository.ObjectMeta.Namespace, repository.ObjectMeta.Name) | |||
| // TODO: implement | |||
| return b.cacheRepository(ctx, repository) | |||
There was a problem hiding this comment.
| return b.cacheRepository(ctx, repository) | |
| var repoList configapi.RepositoryList | |
| if err := b.coreClient.List(ctx, &repoList); err != nil { | |
| return err | |
| } | |
| return b.cache.UpdateRepository(ctx, repository) |
There was a problem hiding this comment.
I think if we include a check on the core client to make sure that the repositories can still be listed (that is that the core client is still alive) then it would be good. See the code for the delete case, that is what they are doing there.
|
@mansoor17syed: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamfallon, mansoor17syed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.