Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #631 where slight differences seen in Kptfile upstream format… #165

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mansoor17syed
Copy link

This push fixes issue #631

…ting with kpt pkg get and kpt alpha rpkg clone
Copy link

linux-foundation-easycla bot commented Dec 24, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

nephio-prow bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mansoor17syed
Once this PR has been reviewed and has the lgtm label, please assign efiacor for approval by writing /assign @efiacor in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ting with kpt pkg get and kpt alpha rpkg clone
@liamfallon
Copy link
Member

liamfallon commented Jan 6, 2025

Hi @mansoor17syed thanks for taking on this issue. The kpt alpha repo and kpt alpha rpkg commands have been deprecated by the porchctl command. I think this issue is likely to be still there in porchctl. I wonder if you could verify that. It's probably the porchctl rpkg get and porchctl rpkg clone commands that should be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants