-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example KPT package with subpackages #91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. will use this to debug #827 and add a test case using this package also.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Catalin-Stratulat-Ericsson, liamfallon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to add this and any other "test" pkgs to the examples repo?
https://github.com/nephio-project/nephio-example-packages
I had planned to move some of the other test pkgs there too. ie. https://github.com/nephio-project/porch/blob/main/test/e2e/e2e_test.go#L90
OK I'll do that |
This PR is replaced by nephio-project/nephio-example-packages#91 |
This is an example demo package with two levels of subpackages, with the main package and all its subpackages deploying
separate deployments of nginx
The package has the following structure: