Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example KPT package with subpackages #91

Closed
wants to merge 5 commits into from

Conversation

liamfallon
Copy link
Member

@liamfallon liamfallon commented Jan 6, 2025

This is an example demo package with two levels of subpackages, with the main package and all its subpackages deploying
separate deployments of nginx

The package has the following structure:

main--+--sub1--+--sub1sub1
      |        |
      |        +--sub1sub2
      |
      +--sub2--+--sub2sub1
               |
               +--sub2sub2

@nephio-prow nephio-prow bot requested review from dkosteck and vjayaramrh January 6, 2025 14:55
@nephio-prow nephio-prow bot added the approved label Jan 6, 2025
@liamfallon liamfallon changed the title Example subpackage Example KPT package with subpackages Jan 6, 2025
@liamfallon
Copy link
Member Author

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. will use this to debug #827 and add a test case using this package also.

Copy link
Contributor

nephio-prow bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@efiacor efiacor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to add this and any other "test" pkgs to the examples repo?
https://github.com/nephio-project/nephio-example-packages

I had planned to move some of the other test pkgs there too. ie. https://github.com/nephio-project/porch/blob/main/test/e2e/e2e_test.go#L90

@liamfallon
Copy link
Member Author

Would it be better to add this and any other "test" pkgs to the examples repo? https://github.com/nephio-project/nephio-example-packages

I had planned to move some of the other test pkgs there too. ie. https://github.com/nephio-project/porch/blob/main/test/e2e/e2e_test.go#L90

OK I'll do that

@liamfallon
Copy link
Member Author

This PR is replaced by nephio-project/nephio-example-packages#91

@liamfallon liamfallon closed this Jan 21, 2025
@liamfallon liamfallon deleted the example-subpackage branch January 21, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants