Adding O2IMS CRD for create cluster story

[dkosteck]

This O2IMS CRD is defined for the northbound API of Nephio, and data will be given by FOCOM. Therefore we should respect the data that FOCOM will provide, and in Specs a Provisioning Request is defined and there is no notion of namespaces

[nephio-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign s3wong for approval by writing /assign @s3wong in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[arora-sagar]

I am fine with the MR.

We can remove the line until we do not add the kube-builder code here.

[henderiw]

this is not a good api definition. You dont call something a provisionRequest. K8s apis are about the what not the how.
also the scope cluster is not good in my view as this constraints things a lot for no reason. this is about requesting clusters again.

[arora-sagar]

this is not a good api definition. You dont call something a provisionRequest. K8s apis are about the what not the how. also the scope cluster is not good in my view as this constraints things a lot for no reason. this is about requesting clusters again.

@henderiw I understand the term "Requests" is not suitable. But it comes from O-RAN cluster provisioningRequest. This CRD was accepted in the last WG2 (O-RAN meeting). Now, we need to discuss this in the meeting to change it.

I am fine in changing from cluster scope to namespace

[arora-sagar]

@gvbalaji Do you have some comments?

[gvbalaji]

Yes as @arora-sagar mentioned this is the CRD from O-RAN specs we're using as is and adapting to our internal implementation. This is used for our thin IMS implementation.

[henderiw]

ORAN should follow the k8s principles. it is not because it is approved there we have to accept it. You don't call a CRD kind using verbs. A k8s api/crd should be about what the resource is about. it should be Cluster or ClusterClaim and given you have a oran group it is relevant in the oran context.

[gvbalaji]

What we are doing here is writing an IMS implementation for provisioning. As part of the O-RAN intersection , this effort is to write the IMS service for the O-RAN API. We are not changing their API.

[gupta-alok]

I agree with @arora-sagar and @gvbalaji. The scope and objective of this PR is to implement O-RAN defined constructs and APIs. We in Nephio shall not change (rename) O-RAN defined IOCs such as ProvisioningRequest for lifecycle management of O-Cloud Node Clusters as well as O-Cloud Infrastructure resource(s).

Nephio-based O-Cloud IMS implementation will have its internal Nephio CRs such as ClusterClaim and WorkloadCluster CRs.

The ClusterClaim CR will model the request to create a cluster with a certain configuration while the current WorkloadCluster CR will be used to model successfully deployed clusters and used as a target for NF Deployment. The design details regarding Create O-Cloud Node Cluster User Story can be found here: https://docs.google.com/presentation/d/1iyE_XLkBJkl_ClYsE_vRnEkm8Ica7YE0/edit#slide=id.p1

[nephio-prow]

@dkosteck: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
presubmit-api-fossology	301f599	link	true	/test presubmit-api-fossology

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.