Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding test for latest versions of python and django #215

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kirmola
Copy link

@kirmola kirmola commented Jan 23, 2025

Description

Describe:

  • Content of the pull request
  • Feature added / Problem fixed

References

Provide any github issue fixed (as in Fix #XYZ)

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@protoroto
Copy link
Member

@kirmola Thanks for contributing! In order to make the CI pass, we need a few changes here.

  • I've opened an issue about this, to better track things -> Test agains python 3.12, 3.13 and Django 5.1 #216
  • Could you please rename your branch to something like feature/issue-216-add-python-3.12-3-13-and-django-5.1-to-test-matrix ?
  • Could you please create a changes/216.feature file, with content something like Add python 3.12, python 3.13 and Django 5.1 to test matrix? That's the text that will go in the HISTORY.rst file and in the changelog of the new release
  • Given that we're adding compatibility with newer python and Django version, we should also update tox.ini file here https://github.com/nephila/django-meta/blob/develop/tox.ini#L11 and add the new Django costraint below here https://github.com/nephila/django-meta/blob/develop/tox.ini#L18 , so that locally tests will test against these new versions.
  • Django 5.1 is only compatible with python >= 3.10 , so we should exclude python3.9-django5.1 both in tox.ini and .github/workflows/test.yml

If you need any help for these things, I'm more than happy to help you. Thanks again for opening this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants