Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Fix blocks sometimes missing ambient occlusion #1618

Draft
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented Oct 23, 2024

This PR fixes blocks sometimes missing ambient occlusion on a vertical or horizontal face (depends on orientation).
The caveat behind this fix is that it reverts the AO fix implemented in #1370, which is why I'm opening this as a draft for now.

Fixes #1613.

@XFactHD XFactHD added bug A bug or error rendering Related to rendering 1.21.3 Targeted at Minecraft 1.21.3 labels Oct 23, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Oct 23, 2024

  • Publish PR to GitHub Packages

Last commit published: d146bf9d1b9e6dc1b79737e57e7aafaaf158e7a4.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1618' // https://github.com/neoforged/NeoForge/pull/1618
        url 'https://prmaven.neoforged.net/NeoForge/pr1618'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1618.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1618
cd NeoForge-pr1618
curl -L https://prmaven.neoforged.net/NeoForge/pr1618/net/neoforged/neoforge/21.3.2-beta-pr-1618-block_shadows/mdk-pr1618.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.21.3] In some cases, the blocks have no shadow.
1 participant