Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.3] Render Minecraft logo as builtin mods logoFile #1617

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from
Open

[1.21.3] Render Minecraft logo as builtin mods logoFile #1617

wants to merge 1 commit into from
+34 −24

Conversation

ApexModder
Copy link
Contributor

@ApexModder ApexModder commented Oct 23, 2024 •
edited
Loading

Redirects mod container logoFile generation/rendering to simply render the built in vanilla logo png file when viewing the built in Minecraft mod info.

Fixes #1616 depends on #1615

Before

image

After

image

@ApexModder ApexModder added enhancement New (or improvement to existing) feature or request 1.21.2 Targeted at Minecraft 1.21.2 labels Oct 23, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Oct 23, 2024 •
edited
Loading

  • Publish PR to GitHub Packages

Last commit published: 86fa3ac69f08bd0bd53cac6560ab4656b909f8bc.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1617' // https://github.com/neoforged/NeoForge/pull/1617
        url 'https://prmaven.neoforged.net/NeoForge/pr1617'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1617.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1617
cd NeoForge-pr1617
curl -L https://prmaven.neoforged.net/NeoForge/pr1617/net/neoforged/neoforge/21.3.4-beta-pr-1617-pr-mc-logo/mdk-pr1617.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@ApexModder ApexModder added 1.21.3 Targeted at Minecraft 1.21.3 and removed 1.21.2 Targeted at Minecraft 1.21.2 labels Oct 23, 2024
@ApexModder ApexModder mentioned this pull request Oct 23, 2024
Merged
@IMS212
Copy link

IMS212 commented Oct 23, 2024

very little nitpick; would it be possible for the logo to be moved down a little to the text? It's extremely uncomfortable to look at.

thinking something like this

image

@ApexModder
Copy link
Contributor Author

ApexModder commented Oct 23, 2024 •
edited
Loading

The way this is implemented I do not have access to the positional data, only the width/height which is using constants from LogoRenderer (256x64).

That being said what you provided doesnt look moved necessarily, just larger in size, might I ask how large yours is?

@ApexModder
Copy link
Contributor Author

Rebased to include #1615 rather than needing to be manually applied locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.21.3 Targeted at Minecraft 1.21.3 enhancement New (or improvement to existing) feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a logo for “Minecraft” in the mods list
2 participants
@ApexModder @IMS212