-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Enable Storage tests for (MacOS) #3568
Conversation
run: | | ||
brew install leveldb | ||
dotnet build | ||
cp -vp /opt/homebrew/Cellar/leveldb/1.23_1/lib/libleveldb.dylib ./tests/Neo.Plugins.Storage.Tests/bin/Debug/net8.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This instruction will fail with the next dotnet version upgrade. We'd better fetch dotnet version from environment to construct the destination path for cp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to update all these files anyways. If we upgrade plus dotnet 9.0 is STS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to update all these files anyways.
But it would be nice to make as less changes as possible during the update. Looks like a good practice to me.
Change Log
Type of change
How Has This Been Tested?
Checklist: