A simpler impl for ByteArrayEqualityComparer and remove redundant impl

src/Neo.Extensions/ByteArrayEqualityComparer.cs

@@ -0,0 +1,35 @@
+// Copyright (C) 2015-2024 The Neo Project.
+//
+// ByteArrayEqualityComparer.cs file belongs to the neo project and is free
+// software distributed under the MIT software license, see the
+// accompanying file LICENSE in the main directory of the
+// repository or http://www.opensource.org/licenses/mit-license.php
+// for more details.
+//
+// Redistribution and use in source and binary forms with or without
+// modifications are permitted.
+
+using System.Collections.Generic;
+using System.IO.Hashing;
+using System.Linq;
+
+namespace Neo.Extensions
+{
+    public class ByteArrayEqualityComparer : IEqualityComparer<byte[]>
+    {
+        public static readonly ByteArrayEqualityComparer Default = new();
+
+        public bool Equals(byte[]? x, byte[]? y)
+        {
+            if (ReferenceEquals(x, y)) return true;
+            if (x is null || y is null || x.Length != y.Length) return false;
+
+            return x.SequenceEqual(y);
+        }
+
+        public int GetHashCode(byte[] obj)
+        {
+            return (int)XxHash3.HashToUInt64(obj);
+        }
+    }
+}

src/Neo.Extensions/Neo.Extensions.csproj

@@ -11,6 +11,7 @@
 
   <ItemGroup>
     <PackageReference Include="Akka" Version="1.5.26" />
+    <PackageReference Include="System.IO.Hashing" Version="8.0.0" />
   </ItemGroup>
 
   <ItemGroup>

src/Neo/IO/Caching/ECPointCache.cs

@@ -10,6 +10,7 @@
 // modifications are permitted.
 
 using Neo.Cryptography.ECC;
+using Neo.Extensions;
 
 namespace Neo.IO.Caching
 {

src/Neo/Persistence/MemorySnapshot.cs

@@ -9,6 +9,7 @@
 // Redistribution and use in source and binary forms with or without
 // modifications are permitted.
 
+using Neo.Extensions;
 using Neo.IO;
 using System.Collections.Concurrent;
 using System.Collections.Generic;

src/Neo/Persistence/MemoryStore.cs

@@ -9,6 +9,7 @@
 // Redistribution and use in source and binary forms with or without
 // modifications are permitted.
 
+using Neo.Extensions;
 using Neo.IO;
 using System.Collections.Concurrent;
 using System.Collections.Generic;

src/Plugins/MPTTrie/Cryptography/MPTTrie/Trie.Proof.cs

@@ -9,7 +9,7 @@
 // Redistribution and use in source and binary forms with or without
 // modifications are permitted.
 
-using Neo.IO;
+using Neo.Extensions;
 using Neo.Persistence;
 using System;
 using System.Collections.Generic;

tests/Neo.UnitTests/IO/UT_ByteArrayEqualityComparer.cs → tests/Neo.Extensions.Tests/UT_ByteArrayEqualityComparer.cs

@@ -14,7 +14,7 @@
 using System;
 using System.Linq;
 
-namespace Neo.UnitTests
+namespace Neo.Extensions.Tests
 {
     [TestClass]
     public class UT_ByteArrayEqualityComparer