-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move]
Part-6 Classes into Different Library - Neo.Extensions
#3410
base: master
Are you sure you want to change the base?
[Move]
Part-6 Classes into Different Library - Neo.Extensions
#3410
Conversation
…`, `AssemblyExtensions`, `StringExtensdions` Deleted `Helper.cs` file
…8/neo into rebuild/the-split-2
/// </summary> | ||
/// <param name="data">The compressed data.</param> | ||
/// <param name="maxOutput">The maximum data size after decompression.</param> | ||
/// <returns>The original data.</returns> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that adding new methods will make it easier to do the work, and actually it wont cause any trouble, but please avoid doing so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, please don't add if the PR is so big and is not related with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@superboyiii could you check if there are any storage change in both networks?
Description
Reorganized and move classes from
neo
library toneo.extensions
library.Fixed problems and warnings that occurred. Along with naming violations.
Change Log
Neo.IO.Helper
classBinaryReaderExtensions
,BinaryWriterExtensions
,MemoryReaderExtensions
,SpanExtensions
classesStringExtensions
,ByteExtensions
MemoryExtensions
using
statementType of change
How Has This Been Tested?
Checklist: