-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new Testing environment #890
Conversation
…t/neo-devpack-dotnet into core-create-artifacts
|
||
The currently known limitations are: | ||
|
||
- Receive events during the deploy, because the object is returned after performing the deploy, it is not possible to intercept notifications for the deploy unless the contract is previously created with `FromHash` knowing the hash of the contract to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good to known.
Later, maybe we could create a function to facilitate with an example of a calculation of a hash and the track of this event.
@shargon, updated devcontainer here to facilitate the verification of tests |
Is the solution file correct? Should not it be more clean, because everything from the submodule is being added there. |
This reverts commit 04cc1ef.
https://github.com/neo-project/neo-express/tree/master/src/test-harness |
I can take ideas about stacked invocations, thanks! |
https://github.com/neo-project/neo-express/tree/master/src/assertions ? Collecting Code Coverage Data - https://github.com/neo-project/neo-express/tree/master/src/collector? Could use this for contract code coverage If any of that helps. |
I think it is feasible to calculate the coverage, and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really think you should look into a mocking framework like moq
. However it looks good, could be great but a great start. After questions answered or no more changes I will approve.
EDIT:
Fix #890 (comment) or explain in document
@cschuchardt88 @Jim8y merge? I will improve it in a new PR (Gas cost per instruction and method) |
👍 💯 I'll be adding the |
I need this merged to continue working on, Improvements can be incorporated in future pull requests. |
* master: [Framework Add] predefine manifest (neo-project#903) TestEngine: Get instruction coverage and move to net standard (neo-project#898) remove disable PublishToGithub (neo-project#901) Added `publish` to `github packages` and fix submodules (neo-project#899) bug: Fix default value when Stored (neo-project#895) Modify changelog during release (neo-project#900) Fixed `PackageReference` for `neo` (neo-project#897) cancel optimization on exception fix catch new Testing environment (neo-project#890) Updated submodule neo (neo-project#892) Update and fix Nep17 template (neo-project#891)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reviewing today.
Part of #889
Require neo-project/neo#3134 #892