break the method convert #813
Conversation
…to break-converter * 'master' of github.com:neo-project/neo-devpack-dotnet: Set nullableContextOptions (neo-project#687) # Conflicts: # src/Neo.Compiler.CSharp/MethodConvert.cs
|
@shargon please review |
|
We said first bugs then optimization a features xD |
@shargon this is exactly for adding tests, comments, documents, and checking bugs. Take a look how easy it became to check what test is missing:
|
|
@Liaojinghui neo-project/neo#2955 Point 2 🙄 Also, we already agree to focus on bugs first.
Review this PR require to review all the 58 changed files, it spend a ton of time for ensuring that the logic was not changed, I'm agree that it's better like you did, but small PR are easy to review. |
|
Not changing a single line of code, just split the big file. Not in a hurry. |
|
I will close this pr to break the changes step by step into smaller prs. |
This pr changes no logic to the compiler but only break the 5000 line
methodconvertfile into multiple subfiles.For the ease of maintaing the compiler and possibly add more features to the compiler, we need to break this super huge file to make it clear how neo compile C# into NEF.
Why we need this pr?
we need to have a detailed document to tell the developers what part of C# is supported, having that document requires a thourough understanding of the compiler. And making the compile process clear helps us understand the code.
Current compiler still misses some of C# features, we need a clear structure to check what is missing.