Skip to content

Commit

Permalink
Merge pull request #96 from nennigb/fix-issue-for-building-docker-con…
Browse files Browse the repository at this point in the history
…tainer

Fix issue for building docker container (complements)
  • Loading branch information
luclaurent authored Dec 14, 2024
2 parents fa5d577 + 53aa069 commit bc972e9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@ jobs:
uses: actions/checkout@main
- name: Set up Docker Buildx
id: buildx
uses: docker/setup-buildx-action@main
uses: docker/setup-buildx-action@master
- name: Login to Github Packages
uses: docker/login-action@main
uses: docker/login-action@master
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.PAT }}
- name: 'Build:dockerimage'
id: docker_build
uses: docker/build-push-action@main
uses: docker/build-push-action@master
with:
# relative path to the place where source code with Dockerfile is located
context: ./docker
Expand Down
2 changes: 1 addition & 1 deletion amc2moodle/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '2.11.0'
__version__ = '2.12.0'
2 changes: 1 addition & 1 deletion docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ The container proposes to mount two volumes:
- `/tmp/work` (**mandatory mount**) that must be link to a specific folder on the host computer
- `/tmp/daemon` (optional mount) that store the log file of the daemon

For instance, the container can be run in CLI (in detached mode) with the following command (*by relacing `DIRA` and if necessary `DIRB`):
For instance, the container can be run in CLI (in detached mode) with the following command (*by replacing `DIRA` and if necessary `DIRB`):
```
docker run --name amc2moodle -d -v "DIRA:/tmp/work" -v "DIRB:/tmp/daemon" ghcr.io/nennigb/amc2moodle
```
Expand Down

0 comments on commit bc972e9

Please sign in to comment.