Byte wise comparison #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GET, enhanced the http.asm file to loop through the array and set the request type when found
|
Hi, thanks for the PR. On my end the server is segfaulting on head requests now with this change, were you able to test it? |
|
Hi sorry i took so long to replay, i just added a commit to the PR that should fix the problem with the HEAD request, thank you |
|
It seems to be working, but I'm missing something, how does this work? If req_type_ptrs was like: Edit: Looking at this more, I don't think it's working. Even on HEAD requests, the entire file is still sent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
pointer array for request types, this will make it more maintainable, if you want to add a request type then you can add it to the array in data.asm
Changed:
the get_check and head_check method, this is now a loop that runs until one of the strings are matched in the above mentioned array
this is a pull request for the issue #37 , Byte-wise comparison of HEAD, GET, etc.