Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix getting kernel versions for debian/proxmox #1

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Mar 16, 2022

Dear Mike,

first things first: Thanks a stack for conceiving and maintaining this excellent program.

We are running two Proxmox machines using their PVE kernel which has a slightly different signature than vanilla Debian kernels. With the adjustments in this patch, the program will start working in those environments as well. We hope you like them.

With kind regards,
Andreas.

P.S.: While we used the canonical check_running_kernel beforehand, we found it hard to extend, see bzed/pkg-nagios-plugins-contrib#91. On this very matter, for supporting PVE kernels, we also created bzed/pkg-nagios-plugins-contrib#92.

/cc @proxmox, @ThomasLamprecht, @Fabian-Gruenbichler

check_kernel Show resolved Hide resolved
check_kernel Show resolved Hide resolved
@neingeist
Copy link
Owner

Notification emails went to an unloved email folder, so I didn't notice for the last two weeks. I'll have a look, I promise!

Copy link
Owner

@neingeist neingeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

check_kernel Show resolved Hide resolved
@neingeist neingeist merged commit 27e430c into neingeist:master Mar 31, 2022
check_kernel Show resolved Hide resolved
@neingeist neingeist mentioned this pull request Apr 2, 2022
@amotl amotl deleted the pve branch April 3, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants