Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prealignment from ncov-ingest, save computation time #23

Open
corneliusroemer opened this issue Nov 5, 2021 · 5 comments
Open

Use prealignment from ncov-ingest, save computation time #23

corneliusroemer opened this issue Nov 5, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

corneliusroemer commented Nov 5, 2021

Doesn't seem to run daily though as of now, this would be the endpoint s3://nextstrain-ncov-private/aligned.fasta.xz

Blocked until daily updates.

Edit: seems to run most weekdays, so unblocked

@corneliusroemer corneliusroemer added blocked Need upstream changes enhancement New feature or request labels Nov 5, 2021
@corneliusroemer corneliusroemer changed the title [Potential Enhancement] Use prealignment from ncov-ingest, save computation [Enhancement] Use prealignment from ncov-ingest, save computation Nov 5, 2021
@corneliusroemer corneliusroemer self-assigned this Nov 5, 2021
@emmahodcroft
Copy link

I think this runs every weekday? Not sure why I don't see one for today - but searching back in the slack, there's one for 4th, (not 3rd - ingest broke), 2nd, 1st, then October 29, 28, 26, 25 (I don't know why not 27th?).
It seems like it's trying to run every weekday, but maybe ingest is breaking now and then?

@corneliusroemer
Copy link
Member Author

Thanks for checking Emma, my Slack search was apparently not as thorough as yours, maybe I don't know the right search query to do it well.

So I'll unblock.

@corneliusroemer corneliusroemer removed the blocked Need upstream changes label Nov 5, 2021
@corneliusroemer corneliusroemer changed the title [Enhancement] Use prealignment from ncov-ingest, save computation Use prealignment from ncov-ingest, save computation time Nov 5, 2021
@emmahodcroft
Copy link

emmahodcroft commented Nov 5, 2021

Well - might still be worth looking into a little - figuring out why it might be failing about once a week? Or implement a check on your side so you know if it worked or not (no use re-running yesterday's stuff).

I just searched for Updated s3://nextstrain-ncov-private/aligned.fasta.xz available.

here's all the dates I find on the first page:

October
M  T  W  R  F  S  S
      6  7  8 
11 12 13 14    16
18 19    21 22
25 26    28 29

Nov
M  T  W  R  F  S  S
1  2     4 

unsure why we seem to have a weakness on Wednesdays and Fridays?

@corneliusroemer
Copy link
Member Author

corneliusroemer commented Nov 5, 2021

You're a star! Wednesdays no new data, maybe?
If it fails Friday, would be nice to just always run Sat/Sun.

@emmahodcroft
Copy link

Looks like at least this Wed & last Wed, ingest broke (different reasons). Wed Oct 20th, we got new metadata and sequences files (so implies new data) but no alignment. No real clue why on slack. Similarly, today we got new metadata & sequences, but no alignment 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants