Add basic support for React Server Components #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a2de02:
|
|
compressed-size: default Size change: +0.03 kB
View unchanged
|
|
@necolas FYI I'm using a local patch very similar to this and it works quite well for me. |
3 tasks
Did you have to make any changes? I didn't hear back from @EvanBacon as to whether this was sufficient |
I also added 'use client' to
But I don't remember if they were "needed" or if I was just adding to everything in sight. I can do some more testing if you think those aren't needed. |
|
@necolas this seems good enough for general usage. Will let you know if we find anything broken. |
Close #2678 Fix #2672 Co-authored-by: evanbacon <[email protected]>
necolas
force-pushed
the
rsc-use-client
branch
from
9a2de02 to
1e795ba
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1e795ba:
|
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Oct 21, 2024
# Why - react-native and react-native-safe-area-context both have "use client" annotations. - use shared server module. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Blocked on necolas/react-native-web#2680 <!-- How did you build this feature or fix this bug and why? --> # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2678
Fix #2672