Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support Persisted Queries #150

Closed
wants to merge 2 commits into from
Closed

Feat: Support Persisted Queries #150

wants to merge 2 commits into from

Conversation

barelyhuman
Copy link
Contributor

@barelyhuman barelyhuman commented Feb 6, 2024 •
edited
Loading

Uses the extracted function in mercurius to avoid duplication of logic and only re-implements functions that now are needed for the same

Depends on mercurius-js/mercurius#1078
Closes #4

Pending

  • Probably also need persisted query per schema instead (needs to be discussed)
  • Safe JSON instead of JSON.parse
  • Subscriptions
  • An easier way to delegate the whole thing (would need larger changes in mercurius)

@barelyhuman barelyhuman self-assigned this Feb 6, 2024
@barelyhuman barelyhuman marked this pull request as draft February 6, 2024 06:02
@barelyhuman barelyhuman changed the title feat(persistedQueries): rudimentary implementation Feat: Support Persisted Queries Feb 6, 2024
simoneb
simoneb reviewed Feb 6, 2024
View reviewed changes
index.js Show resolved Hide resolved
@barelyhuman
Copy link
Contributor Author

Closing in lieu of #152

@barelyhuman barelyhuman closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb left review comments

Assignees

@barelyhuman barelyhuman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support persisted queries
2 participants
@barelyhuman @simoneb