Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable resharding v2 #10303

Merged
merged 5 commits into from
Dec 6, 2023
Merged

enable resharding v2 #10303

merged 5 commits into from
Dec 6, 2023

Conversation

wacban
Copy link
Contributor

@wacban wacban commented Dec 6, 2023

Feature to stabilize

This PR stabilizes the Resharding V2 protocol feature. It introduces a new implementation for resharding and a new shard layout for the production networks - mainnet and testnet. The resharding process from the current shard layout to the new shard layout will be triggered automatically an epoch before the switch to the new protocol version.

Context

Testing and QA

This feature was extensively tested in unit tests, integration tests, nayduck tests, mocknet, testnet and mainnet.

Checklist

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a908de3) 71.81% compared to head (39e7e3a) 71.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10303      +/-   ##
==========================================
- Coverage   71.81%   71.80%   -0.02%     
==========================================
  Files         712      712              
  Lines      143096   143095       -1     
  Branches   143096   143095       -1     
==========================================
- Hits       102771   102751      -20     
- Misses      35615    35633      +18     
- Partials     4710     4711       +1     
Flag Coverage Δ
backward-compatibility 0.08% <0.00%> (ø)
db-migration 0.08% <0.00%> (ø)
genesis-check 1.25% <0.00%> (+<0.01%) ⬆️
integration-tests 36.14% <100.00%> (+<0.01%) ⬆️
linux 71.70% <100.00%> (+0.02%) ⬆️
linux-nightly 71.39% <100.00%> (-0.02%) ⬇️
macos 53.89% <100.00%> (+<0.01%) ⬆️
pytests 1.48% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.28% <0.00%> (+<0.01%) ⬆️
unittests 68.17% <100.00%> (-0.02%) ⬇️
upgradability 0.13% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nikurt nikurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@shreyan-gupta shreyan-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🥳

@wacban wacban added this pull request to the merge queue Dec 6, 2023
Merged via the queue into master with commit 0886a30 Dec 6, 2023
18 of 19 checks passed
@wacban wacban deleted the waclaw-resharding-stabilization branch December 6, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants