Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cargo-near-build as separate import in [dev-dependencies] (examples) #1263

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

virajbhartiya
Copy link
Contributor

Closes #1257

Removed the individual export for cargo-near-build to use the default exported dependency

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (d7c16c8) to head (d386133).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
- Coverage   80.23%   80.20%   -0.03%     
==========================================
  Files         102      102              
  Lines       14598    14598              
==========================================
- Hits        11712    11708       -4     
- Misses       2886     2890       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virajbhartiya
Copy link
Contributor Author

virajbhartiya commented Nov 22, 2024

@dj8yfo can you please suggest me a way to include build_script in the imports

@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 22, 2024

@virajbhartiya please revert the change for build-script. This must be lines for factory-contract.
Importing it directly for build-scripts with additional features is ok, and is somewhat distinct purpose than routinely compiling contracts for tests.
Also these weren't referenced in the issue

@dj8yfo
Copy link
Collaborator

dj8yfo commented Nov 23, 2024

@virajbhartiya together with reverting examples/factory-contract you
removed lines with import use near_workspaces::cargo_near_build;
in tests of examples/fungible-token, examples/lockable-fungible-token, examples/non-fungible-token, did you?
Add these lines, and 6 test jobs should start passing

@dj8yfo dj8yfo marked this pull request as draft November 25, 2024 08:56
@dj8yfo dj8yfo marked this pull request as ready for review December 2, 2024 12:55
@dj8yfo
Copy link
Collaborator

dj8yfo commented Dec 2, 2024

@race-of-sloths score 2

@race-of-sloths
Copy link

@dj8yfo Thank you for calling!

@virajbhartiya Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo dj8yfo changed the title chore: Update dependencies in Cargo.toml files chore: remove cargo-near-build as separate import in [dev-dependencies] (examples) Dec 2, 2024
@dj8yfo dj8yfo merged commit da3f1f4 into near:master Dec 2, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove direct dependency on cargo-near-build in some of examples
3 participants