Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove reference to storage rent #489

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

jakmeier
Copy link
Contributor

Storage rent has been superseded by storage staking a long time ago.
This commit updates the account specification accordingly.

Storage rent has been superseded by storage staking a long time ago.
This commit updates the account specification accordingly.
@jakmeier jakmeier added documentation Improvements or additions to documentation A-Nomicon-Changes An update to the Nomicon documentation. labels Jul 24, 2023
@jakmeier jakmeier requested a review from a team as a code owner July 24, 2023 09:43
@jakmeier
Copy link
Contributor Author

@near/nep-moderators there are many lint failures in lines I didn't touch. Is it required to fix them before merging? Should I do it in this PR or in a separate PR?

@frol frol merged commit 2e0a929 into near:master Jul 30, 2023
2 of 3 checks passed
@frol
Copy link
Collaborator

frol commented Jul 30, 2023

there are many lint failures in lines I didn't touch. Is it required to fix them before merging? Should I do it in this PR or in a separate PR?

@jakmeier Thanks for flagging it! It is not a blocker to merge, but it would be great if you could submit a PR fixing the lints in a separate PR 🙏

@jakmeier jakmeier deleted the rm_account_storage_rent branch August 3, 2023 08:29
@jakmeier
Copy link
Contributor Author

jakmeier commented Aug 3, 2023

filed #493

@frol frol added the S-approved A NEP that was approved by a working group. label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Nomicon-Changes An update to the Nomicon documentation. documentation Improvements or additions to documentation S-approved A NEP that was approved by a working group.
Projects
Status: APPROVED FIXES
Development

Successfully merging this pull request may close these issues.

2 participants