[Astra] rename cleanup : make sure the tests are passing[Rust unit and integration tests] #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amityadav0
changed the title
sczembor
reviewed
Sep 11, 2023
| @@ -161,7 +156,7 @@ impl Contract { | |||
| /// On expired, anyone can call it to free up the claim slot. | |||
| #[payable] | |||
| pub fn bounty_done(&mut self, id: u64, account_id: Option<AccountId>, description: String) { | |||
| let sender_id = account_id.unwrap_or_else(|| env::predecessor_account_id()); | |||
| let sender_id = account_id.unwrap_or_else(env::predecessor_account_id); | |||
There was a problem hiding this comment.
are you sure this will work? it is different type than env::predecessor_account_id()
There was a problem hiding this comment.
I ran cargo lint fix. didn't change it
There was a problem hiding this comment.
we have test for it as well in test_general
sczembor
reviewed
Sep 11, 2023
sczembor
reviewed
Sep 11, 2023
sczembor
reviewed
Sep 11, 2023
sczembor
reviewed
Sep 11, 2023
sczembor
reviewed
Sep 11, 2023
sczembor
reviewed
Sep 11, 2023
Co-authored-by: sczembor <[email protected]>
robert-zaremba
approved these changes
Sep 12, 2023
| @@ -161,7 +156,7 @@ impl Contract { | |||
| /// On expired, anyone can call it to free up the claim slot. | |||
| #[payable] | |||
| pub fn bounty_done(&mut self, id: u64, account_id: Option<AccountId>, description: String) { | |||
| let sender_id = account_id.unwrap_or_else(|| env::predecessor_account_id()); | |||
| let sender_id = account_id.unwrap_or_else(env::predecessor_account_id); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workspacesinstead ofnear-sdk-sim