-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Astra] rename cleanup : make sure the tests are passing[Rust unit and integration tests] #3
Conversation
@@ -161,7 +156,7 @@ impl Contract { | |||
/// On expired, anyone can call it to free up the claim slot. | |||
#[payable] | |||
pub fn bounty_done(&mut self, id: u64, account_id: Option<AccountId>, description: String) { | |||
let sender_id = account_id.unwrap_or_else(|| env::predecessor_account_id()); | |||
let sender_id = account_id.unwrap_or_else(env::predecessor_account_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure this will work? it is different type than env::predecessor_account_id()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran cargo lint fix. didn't change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have test for it as well in test_general
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left few comments
Co-authored-by: sczembor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@@ -161,7 +156,7 @@ impl Contract { | |||
/// On expired, anyone can call it to free up the claim slot. | |||
#[payable] | |||
pub fn bounty_done(&mut self, id: u64, account_id: Option<AccountId>, description: String) { | |||
let sender_id = account_id.unwrap_or_else(|| env::predecessor_account_id()); | |||
let sender_id = account_id.unwrap_or_else(env::predecessor_account_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good
workspaces
instead ofnear-sdk-sim