allow anything inside label

ndx-technologies · Dec 18, 2024 · 0de1b79 · 0de1b79
1 parent 839e47a
commit 0de1b79
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/metric.go b/metric.go
@@ -64,7 +64,7 @@ func ParseMetric(s string) (name string, labels map[string]string, err error) {
 	}
 
 	i := strings.IndexByte(s, '{')
-	j := strings.IndexByte(s, '}')
+	j := strings.LastIndexByte(s, '}')
 
 	if (i == -1) != (j == -1) {
 		return "", nil, ErrInvalidLabel

diff --git a/metric_test.go b/metric_test.go
@@ -97,6 +97,15 @@ func TestParseMetric(t *testing.T) {
 				"b": "b",
 			},
 		},
+		{
+			s:    `http_request_count{code="200",method="GET",path="/api/v1/something/{id}"}`,
+			name: "http_request_count",
+			labels: map[string]string{
+				"code":   "200",
+				"method": "GET",
+				"path":   "/api/v1/something/{id}",
+			},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.s, func(t *testing.T) {
@@ -127,13 +136,13 @@ func TestParseMetric_Error(t *testing.T) {
 		"{}",
 		"asdf{",
 		"asdf}",
-		"asdf{a=\"1}\"}",
 		"asdf}a=\"1}\"{",
 		"asd}f",
 		"asdf{,}",
 		"asdf{=}",
 		"asdf{=a}",
 		"asdf{a=}",
+		"asdf{a=\"b\"}a",
 		"asdf{a=a",
 		"asdf{a=a,",
 		"asdf{a=a,}",