Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: body used already error fix #340 #346

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix: body used already error fix #340 #346

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1292baa
fix: body used already error fix #340
Ephigenia Feb 27, 2023
2f0a33c
fix: adds await
Ephigenia Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/httpadapter/fetchadapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,11 @@ class FetchAdapter {
if (fullResponse) {
return res;
}
const rawResponseBody = res.text();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need an await here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the await

try {
return await res.json();
return JSON.parse(rawResponseBody);
} catch (e) {
throw new HttpError(await res.text(), {
throw new HttpError(rawResponseBody, {
code: res.statusCode
});
}
Expand Down