Loosen up heuristic timing test to deal with very slow CI machines

nblumhardt · Jul 8, 2022 · 4cbddad · 4cbddad
1 parent b4c8745
commit 4cbddad
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/src/SerilogTimings/CompletionBehaviour.cs b/src/SerilogTimings/CompletionBehaviour.cs
@@ -20,4 +20,4 @@ enum CompletionBehaviour
         Complete,
         Silent
     }
-}
+}
diff --git a/src/SerilogTimings/Extensions/LoggerOperationExtensions.cs b/src/SerilogTimings/Extensions/LoggerOperationExtensions.cs
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-using System;
 using Serilog;
 using Serilog.Events;
 using SerilogTimings.Configuration;

diff --git a/src/SerilogTimings/Operation.cs b/src/SerilogTimings/Operation.cs
@@ -63,11 +63,11 @@ public enum Properties
         readonly long _start;
         long? _stop;
 
-        IDisposable _popContext;
+        readonly IDisposable _popContext;
         CompletionBehaviour _completionBehaviour;
         readonly LogEventLevel _completionLevel;
         readonly LogEventLevel _abandonmentLevel;
-        private readonly TimeSpan? _warningThreshold;
+        readonly TimeSpan? _warningThreshold;
         Exception? _exception;
 
         internal Operation(ILogger target, string messageTemplate, object[] args,

diff --git a/test/SerilogTimings.Tests/OperationTests.cs b/test/SerilogTimings.Tests/OperationTests.cs
@@ -246,7 +246,7 @@ public async Task TimingWithinOrderOfMagnitude(int delay)
             op.Dispose();
 
             var elapsed = GetElapsedMilliseconds(logger);
-            Assert.InRange(elapsed, delay * 0.5, delay * 5);
+            Assert.InRange(elapsed, delay * 0.2, delay * 8);
         }
 
         [Fact]