ci: cleanup slither setup

nayms · Oct 19, 2023 · 2e78123 · 2e78123
1 parent 2c21aba
commit 2e78123
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -65,7 +65,6 @@ jobs:
         env:
           SOLC_VERSION: 0.8.20
         run: make slither
-        continue-on-error: true
 
       - name: Upload Slither SARIF file
         uses: github/codeql-action/upload-sarif@v2

diff --git a/Makefile b/Makefile
@@ -667,7 +667,7 @@ docs: ## generate docs from natspec comments
 	yarn docgen
 
 slither:	## run slither static analysis
-	slither src/diamonds/nayms --exclude solc-version,assembly-usage,naming-convention,low-level-calls --ignore-compile --sarif results.sarif
+	slither src/diamonds/nayms --config-file=slither.config.json --fail-none
 
 upgrade-hash-sepolia: ## generate SEPOLIA upgrade hash
 	@forge script SmartDeploy \

diff --git a/slither.config.json b/slither.config.json
@@ -9,8 +9,10 @@
     "test/=./test/",
     "script/=./script/"
   ],
-  "detectors_to_exclude": "assembly,similar-names,naming-convention",
+  "detectors_to_exclude": "solc-version,assembly-usage,naming-convention,low-level-calls",
   "exclude_informational": false,
   "exclude_low": false,
-  "solc_disable_warnings": false
+  "solc_disable_warnings": false,
+  "ignore_compile": true,
+  "sarif": "results.sarif"
 }