Bug 14229 fixed (SeleniumHQ#14389)

navin772 · Aug 14, 2024 · c3dd52e · c3dd52e
1 parent 5e2a630
commit c3dd52e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/common/src/web/javascriptPage.html b/common/src/web/javascriptPage.html
@@ -279,6 +279,10 @@ <h1>Type Stuff</h1>
   </div>
 </div>
 
+<form id="aParentFormId">
+  <input type="text" name="tagName">
+</form>
+
 </body>
 </html>
 

diff --git a/javascript/atoms/domcore.js b/javascript/atoms/domcore.js
@@ -169,6 +169,11 @@ bot.dom.core.isElement = function (node, opt_tagName) {
   if (opt_tagName && (typeof opt_tagName !== 'string')) {
     opt_tagName = opt_tagName.toString();
   }
+  // because node.tagName.toUpperCase() fails when tagName is "tagName"
+  if (node instanceof HTMLFormElement) {
+    return !!node && node.nodeType == goog.dom.NodeType.ELEMENT &&
+    (!opt_tagName || "FORM" == opt_tagName);
+  }
   return !!node && node.nodeType == goog.dom.NodeType.ELEMENT &&
     (!opt_tagName || node.tagName.toUpperCase() == opt_tagName);
 };

diff --git a/py/test/selenium/webdriver/common/visibility_tests.py b/py/test/selenium/webdriver/common/visibility_tests.py
@@ -29,6 +29,7 @@ def test_should_allow_the_user_to_tell_if_an_element_is_displayed_or_not(driver,
     assert driver.find_element(by=By.ID, value="none").is_displayed() is False
     assert driver.find_element(by=By.ID, value="suppressedParagraph").is_displayed() is False
     assert driver.find_element(by=By.ID, value="hidden").is_displayed() is False
+    assert driver.find_element(by=By.ID, value="aParentFormId").is_displayed() is True
 
 
 def test_visibility_should_take_into_account_parent_visibility(driver, pages):
-Original file line number
+Diff line change
@@ Expand Up / @@ -279,6 +279,10 @@ <h1>Type Stuff</h1> @@
       </div>
     </div>
+    <form id="aParentFormId">
+      <input type="text" name="tagName">
+    </form>
     </body>
     </html>
@@ Expand Down @@