Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/skattekort service bugfix #3577

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

krharum
Copy link
Contributor

@krharum krharum commented Aug 9, 2024

No description provided.

krharum added 3 commits August 9, 2024 09:09
#deploy-skatte-service

Removed the Trekktype class and refactored related code to use Forskuddstrekk directly. Updated mapping strategies and utility to align with the new structure. This change simplifies the data model and improves maintainability.
#deploy-skattekort-service
#deploy-skattekort-service

Renamed `TrekktypeMappingStrategy` to `ForskuddstrekkMappingStrategy` for better clarity. Updated variable names inside the class to align with the new name. Modified `Forskuddstrekk` class by adding `AllArgsConstructor` and changing `SuperBuilder` to `Builder`.
@krharum krharum marked this pull request as ready for review August 9, 2024 08:03
@krharum krharum requested a review from a team as a code owner August 9, 2024 08:03
@krharum krharum merged commit 63de518 into master Aug 9, 2024
222 of 224 checks passed
@krharum krharum deleted the bugfix/skattekort-service-bugfix branch August 9, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant