Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new oppdrag-service application #3498

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from
Draft

Commits on May 28, 2024

  1. Add new oppdrag-service application

    Created a new application called oppdrag-service. This includes java-based application files, Dockerfile, Gradle build system files, and various supporting configuration files. Also added API interface descriptions in WSDL and XSD formats. A basic unit test file was added as well.
    krharum committed May 28, 2024
    Configuration menu
    Copy the full SHA
    8732b81 View commit details
    Browse the repository at this point in the history
  2. Add Oppdrag web service client and update configurations

    Added new OppdragClient class, related configuration, and corresponding consumer and controller. Adjusted build configurations and dependencies for SOAP-based web service compatibility. Replaced reactive-core with
    krharum committed May 28, 2024
    Configuration menu
    Copy the full SHA
    35be286 View commit details
    Browse the repository at this point in the history
  3. Add OppdragRequest DTO class

    A new data transfer object (DTO) class called 'OppdragRequest' is introduced. This class is suited for the Oppdrag service and is equipped with Lombok annotations for data encapsulation, builder pattern support, no-args and all-args constructors.
    krharum committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2cf8f24 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    d2f6105 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. **Refactor project structure and dependencies**

    Remove unnecessary DevConfig and centralize logic under oppdragservice package. Also, streamline build configuration by using dolly-apps plugin and integrating vault library for improved consistency and security management.
    krharum committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1ae4acc View commit details
    Browse the repository at this point in the history
  2. Add Oppdrag service layer implementation

    Introduce OppdragService with a method to handle OppdragRequest and return SendInnOppdragResponse. Also, update OppdragController to integrate with the new service layer and manage incoming requests accordingly.
    krharum committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    03b7b16 View commit details
    Browse the repository at this point in the history
  3. Refactor OppdragRequest: Change String to KodeEndring enum

    Changed the type of `kodeEndring` from String to a new KodeEndring enum to improve type safety and reduce potential errors. Introduced the new KodeEndring enum with values NY, ENDR, and UEND.
    krharum committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    21b3d9b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Configuration menu
    Copy the full SHA
    ca4fbdc View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Add mapping strategy and Swagger adjustments

    Implemented a MapperFacade configuration to handle custom mapping strategies and converters. Improved Swagger setup by refining security configurations and customizing views. Enhanced OppdragRequest DTO with additional schema information and data types for better validation and XML support. Additionally, added basic unit tests for mapping strategies and updated dependencies in the build configuration.
    krharum committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    bd567a1 View commit details
    Browse the repository at this point in the history
  2. Enhance DTO schemas and validation

    Removed unnecessary import, added detailed `@Schema` descriptions, and improved validation constraints for multiple fields within the `OppdragRequest` class. Introduced `ValuteType` enum to streamline currency handling.
    krharum committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    83ee526 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Add custom mappings for LocalDate and LocalDateTime

    Introduced new classes LocalDateCustomMapping and LocalDateTimeCustomMapping to handle custom conversion formats. Updated OppdragRequest and related mapping strategies to use these custom converters. Added unit tests to verify the new mapping logic.
    krharum committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    2099800 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Add TestConfig and Oppdragsdata utility classes

    Added TestConfig.java to provide Spring test configuration, including beans for OppdragService, OppdragConsumer, and MapperFacade. Created Oppdragsdata.java in utility package to facilitate the construction of OppdragRequest and SendInnOppdragResponse objects, enhancing the testing structure.
    krharum committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7d1b54d View commit details
    Browse the repository at this point in the history
  2. Refactor OppdragService to use new OppdragResponse DTO

    Removed TestConfig and updated related test cases to directly use mocks. Modified OppdragService to return and map OppdragResponse instead of SendInnOppdragResponse, enhancing the consistency and maintainability of the service.
    krharum committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    01276b7 View commit details
    Browse the repository at this point in the history
  3. Add missing fields to Oppdragsdata and update tests.

    Extended the Oppdragsdata class with `datoTekstTom`, `tekstKode`, and `feilreg` fields. Updated corresponding test cases in OppdragResponseMappingStrategyTest to ensure the new fields are properly validated.
    krharum committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    72c562c View commit details
    Browse the repository at this point in the history
  4. Add oppdrag-service GitHub Actions workflow

    #deploy-oppdrag-service
    
    Created a new workflow configuration for the oppdrag-service in the GitHub Actions. Updated `config.yml` by removing unused application entries and redundant reply URLs.
    krharum committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    b99ccea View commit details
    Browse the repository at this point in the history
  5. Update Oppdragsdata.java and Dockerfile #deploy-oppdrag-service

    Enhanced the builder pattern in Oppdragsdata by adjusting line breaks for improved readability. Updated Dockerfile to include necessary Java module permissions to avoid runtime issues.
    krharum committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    27257c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Refactor date and time initialization logic.

    #deploy-oppdrag-service
    
    Changed the LOCAL_DATE and LOCAL_DATE_TIME initializations to use fixed values for consistency in tests. Reformatted DB2_DATE_TIME_FORMAT and adjusted its parsing mechanism accordingly.
    krharum committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ad7f2ec View commit details
    Browse the repository at this point in the history
  2. Refactor Oppdrag components.

    #deploy-oppdrag-service
    
    Correct enum naming from `ValuteType` to `ValutaType` in various classes, and add a new `KodeverkService` for retrieving code values. This also includes new mappings in `OppdragController` and `OppdragKodeverk` to handle these enums.
    krharum committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    08bac2d View commit details
    Browse the repository at this point in the history
  3. Refactor Dockerfile and cleanup code

    #deploy-oppdrag-service
    
    Replaced ADD with COPY in Dockerfile and reordered JAVA_OPTS. Added @requiredargsconstructor to OppdragKodeverk enum and removed redundant constructor. Removed @VaultPropertySource from DevConfig for dev profile configuration.
    krharum committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    810bea3 View commit details
    Browse the repository at this point in the history
  4. Fix main class path in build.gradle

    #deploy-oppdrag-service
    
    Corrected the main class path in the bootJar configuration of build.gradle. This change updates the path to align with the actual package structure, ensuring the application starts correctly.
    krharum committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3d9565d View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Initialize oppdrag-proxy project structure

    #deploy-proxy-oppdrag
    
    Add essential configuration files and setup for oppdrag-proxy, including Gradle build scripts, Dockerfile, application properties, and workflow definitions. The initial setup also includes basic logging, security, and routing configurations for the project.
    krharum committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    6f9bae6 View commit details
    Browse the repository at this point in the history
  2. Add Spring Cloud starter bootstrap dependency

    #deploy-proxy-oppdrag
    
    Included `spring-cloud-starter-bootstrap` for legacy bootstrap configuration. This will be temporarily used and should be removed once the new configuration is implemented.
    krharum committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c814b41 View commit details
    Browse the repository at this point in the history
  3. Remove unused dependencies and test properties file

    #deploy-proxy-oppdrag
    
    Deleted the `application-test.properties` file as it's no longer needed. Also removed the `data-transfer-objects` library from settings.gradle and build.gradle dependencies to clean up the codebase.
    krharum committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    b422f93 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Disable vault in config

    #deploy-proxy-oppdrag
    
    Removed the vault configuration from the config.yml file. This change ensures that the vault is no longer enabled by default, simplifying resource allocation and management.
    krharum committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    711bc51 View commit details
    Browse the repository at this point in the history
  2. Refactor OppdragService to use WebClient

    Replaced OppdragConsumer with OppdragWSConsumer and introduced WebClient for communication. Added new configuration classes for server properties and consumers. Updated application.yml to include new endpoint configurations and modified tests accordingly.
    krharum committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    713b43f View commit details
    Browse the repository at this point in the history
  3. Set cluster to "dev-fss" in workflow

    #deploy-oppdrag-service
    
    Added the "cluster" parameter to the GitHub workflow configuration for the oppdrag-service application. This change specifies the deployment environment as "dev-fss", ensuring the service will be deployed correctly in the intended cluster.
    krharum committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    978776a View commit details
    Browse the repository at this point in the history
  4. Remove vault configuration from config.yml

    #deploy-oppdrag-service
    
    This commit removes the vault configuration section as it is no longer needed. The min and max replicas settings remain unchanged, maintaining the desired state for replicas.
    krharum committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0ef42fe View commit details
    Browse the repository at this point in the history
  5. Change workflow name to oppdrag-service

    This commit changes the name of the workflow from "oppsummeringsdokument-service" to "oppdrag-service". This update ensures that the workflow name accurately reflects the intended service.
    krharum committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a365043 View commit details
    Browse the repository at this point in the history
  6. Add cluster configuration for inbound rules in config.yml #deploy-opp…

    …drag-service
    
    Each application in the inbound rules now includes a cluster specification, set to 'dev-gcp'. This ensures all specified applications route correctly through the designated cluster in the development environment.
    krharum committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4b0c7be View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Remove Reactor Mono from OppdragService

    #deploy-oppdrag-service
    
    Updated OppdragService to return OppdragResponse directly instead of using Reactor Mono. This simplifies the response handling and aligns the test cases with the new service method signature. Also, removed unused imports and corrected SoapActionCallback usage in the consumer.
    krharum committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    db1a6c0 View commit details
    Browse the repository at this point in the history
  2. Handle SendInnOppdragFeilUnderBehandling exception

    #deploy-oppdrag-service
    
    Add a try-catch block to specifically catch and log details of SendInnOppdragFeilUnderBehandling exceptions. This improves error logging by providing more context about the error cause and source, while still logging general exceptions.
    krharum committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    4bea706 View commit details
    Browse the repository at this point in the history
  3. Remove redundant SoapActionCallback.

    #deploy-oppdrag-service
    
    The SoapActionCallback argument was removed from the marshalSendAndReceive method call as it was deemed unnecessary. This cleanup enhances code readability and maintainability without altering the function's core behavior.
    krharum committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    23ec4e9 View commit details
    Browse the repository at this point in the history
  4. Handle SoapFaultClientException in OppdragWSConsumer

    #deploy-oppdrag-service
    
    Added a specific case to handle SoapFaultClientException in the exception block of OppdragWSConsumer. This logs detailed information about the SOAP fault, including faultCode and faultStringOrReason, improving error diagnosis and monitoring.
    krharum committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    07bc5ff View commit details
    Browse the repository at this point in the history
  5. Update error logging for SOAP faults in OppdragWSConsumer #deploy-opp…

    …drag-service
    
    Removed handling of `SendInnOppdragFeilUnderBehandling` exception and enhanced logging details for `SoapFaultClientException`. This change ensures more comprehensive error information is captured when SOAP faults occur.
    krharum committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    8c6b7e5 View commit details
    Browse the repository at this point in the history
  6. Update error logging for SOAP faults in OppdragWSConsumer #deploy-opp…

    …drag-service
    
    Removed handling of `SendInnOppdragFeilUnderBehandling` exception and enhanced logging details for `SoapFaultClientException`. This change ensures more comprehensive error information is captured when SOAP faults occur.
    krharum committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ce89fc7 View commit details
    Browse the repository at this point in the history
  7. Improve SOAP fault detail logging

    Switched from generic Object to DOMResult for SOAP fault details extraction. Enhanced logging by adding detailed node information such as systemId, nodeName, nodeValue, nodeType, and nextSibling. This will facilitate better debugging and troubleshooting of SOAP faults.
    krharum committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    176e9f6 View commit details
    Browse the repository at this point in the history
  8. Refactor SoapFaultDetailElement processing logic

    #deploy-oppdrag-service
    
    Introduce a helper method to encapsulate node information extraction from SoapFaultDetailElement. This improves code readability and centralizes the logic for easier maintenance and potential future modifications.
    krharum committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9f3c2e6 View commit details
    Browse the repository at this point in the history