Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use hostname instead of canonicalHostname #586

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix: use hostname instead of canonicalHostname #586

merged 2 commits into from
Nov 6, 2023

Conversation

tronghn
Copy link
Contributor

@tronghn tronghn commented Nov 6, 2023

Fixes #582.

@tronghn tronghn requested a review from a team as a code owner November 6, 2023 12:32
ybelMekk
ybelMekk approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@ybelMekk ybelMekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, LGTM

@ybelMekk ybelMekk merged commit f90b563 into master Nov 6, 2023
3 checks passed
@ybelMekk ybelMekk deleted the canonicalhostname branch November 6, 2023 13:51
@ybelMekk ybelMekk added the bug Something isn't working label Nov 6, 2023
@tronghn tronghn mentioned this pull request Nov 6, 2023
Closed
@ybelMekk ybelMekk linked an issue Nov 17, 2023 that may be closed by this pull request
Valid authorization tokens rejected in version 0.5.4 and above #380
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ybelMekk ybelMekk ybelMekk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@tronghn @ybelMekk