Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use sass instead of node-sass #891

Merged
merged 1 commit into from
Oct 17, 2024
Merged

refactor: use sass instead of node-sass #891

merged 1 commit into from
Oct 17, 2024

Conversation

malangfox
Copy link
Contributor

Details

sass/node-sass#3420
We need to replace the node-sass using in @egjs/flicking with sass.

  • build:sass script has been changed.
  • Since sass doesn't automatically insert prefixes for specific browsers, added some verdor prefixes to flicking.sass

@naver naver deleted a comment from CLAassistant Sep 25, 2024
@coveralls
Copy link

Coverage Status

coverage: 82.889%. remained the same
when pulling 8f87338 on malangfox:refactor/node-sass-to-sass
into 3b18491 on naver:master.

@malangfox malangfox merged commit c106ab4 into naver:master Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ave10987 ave10987 Awaiting requested review from ave10987

@daybrush daybrush Awaiting requested review from daybrush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malangfox @coveralls