-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix broken layout when direction rtl is applied #836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/Flicking.ts
Outdated
@@ -1511,6 +1520,7 @@ class Flicking extends Component<FlickingEvents> { | |||
camera.updateAdaptiveHeight(); | |||
camera.updateOffset(); | |||
await renderer.render(); | |||
this._updatePanelOrder(camera); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to move to the camera class method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified updatePanelOrder
to camera class method.
You can check the most recent commit.
updatePanelOrder
requires flicking.control.controller.updateDirection();
to be called.
Should this be the camera class method, even though it interferes with flicking's controller?
583246d
to
25b505e
Compare
Issue
#835
Details
This issue fixes the layout breaking when
direction: rtl
is applied to the viewport.