Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERNAL: Remove whitespace in all files #344

Closed
wants to merge 1 commit into from
Closed

INTERNAL: Remove whitespace in all files #344

wants to merge 1 commit into from

Conversation

ing-eoking
Copy link
Collaborator

@ing-eoking ing-eoking commented Jan 23, 2025 •
edited
Loading

๐Ÿ”— Related Issue

โŒจ๏ธ What I did

  • ์ „์ฒด ํŒŒ์ผ์—์„œ whitespace๋ฅผ ์ œ๊ฑฐํ•ฉ๋‹ˆ๋‹ค.
    • ์ฝ”๋“œ ๋ผ์ธ ๋์— ์กด์žฌํ•˜๋Š” ๊ณต๋ฐฑ ๋ฌธ์ž ์ œ๊ฑฐ
    • ํƒญ ๋ฌธ์ž๋ฅผ ๊ณต๋ฐฑ ๋ฌธ์ž 4๊ฐœ๋กœ ์น˜ํ™˜

@ing-eoking ing-eoking marked this pull request as draft January 23, 2025 01:54
@ing-eoking ing-eoking marked this pull request as ready for review January 23, 2025 05:10
jhpark816
jhpark816 reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ ์™„๋ฃŒ

ChangeLog
* [ENHANCE] ensure more concurrency in memcached pool.
* [CLEANUP] fixed the compile warnings.
* [CLEANUP] refactored serveral parts of code.
* [FEATURE] supported the 3 replicas in replication.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ๋Š” ์–ด๋–ค ๋ฌธ์ž์˜ ๋ณ€๊ฒฝ์ธ๊ฐ€์š”?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ทธ ์™ธ์—๋„ ๋‹จ์ˆœํ•˜์ง€ ์•Š์€ ๋ณ€๊ฒฝ์ด ์žˆ๋‹ค๋ฉด, ๊ฐ„๋‹จํžˆ ์ฝ”๋ฉ˜ํŠธ ๋‚จ๊ฒจ์ฃผ์„ธ์š”.

Copy link
Collaborator Author

@ing-eoking ing-eoking Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1๊ฐœ์˜ tab ๋ฌธ์ž( )๋ฅผ 4๊ฐœ ์ด์ƒ์˜ space ๋ฌธ์ž( )๋กœ ๋ฐ”๊พธ๋Š” ๋ณ€๊ฒฝ์ž…๋‹ˆ๋‹ค.
(๋งˆ์šฐ์Šค๋กœ ๋“œ๋ž˜๊ทธ๋ฅผ ํ•˜๋ฉด ๊ฐœ์ˆ˜ ์ฐจ์ด๋ฅผ ์•Œ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.)

tab ๋ฌธ์ž์˜ ๊ฒฝ์šฐ ํŽธ์ง‘๊ธฐ๋‚˜ IDE๋งˆ๋‹ค ๋‹ค๋ฅด๊ฒŒ ํ‘œ์‹œ๋  ์ˆ˜ ์žˆ์–ด, space ๋ฌธ์ž๋ฅผ ๊ถŒ์žฅํ•œ๋‹ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค.

tab ๋ฌธ์ž ๋ณ€๊ฒฝ๊ณผ ๋’ค์˜ space ์ œ๊ฑฐ ์ด์™ธ์—๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†์Šต๋‹ˆ๋‹ค.

OLD
@@ -19,7 +19,7 @@ Documentation can be found here: http://docs.libmemcached.org/

Want to contribute? If you write more then three good patches, then I will
just ask you to commit directly to the tree. I am happy to have additional
people work on this project. Please checkout README.FIRST.
people work on this project. Please checkout README.FIRST.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฐธ๊ณ ๋กœ, ์ด์™€ ๊ฐ™์ด ๋’ค์— ์žˆ๋Š” space ์ œ๊ฑฐํ•œ ๊ฒฝ์šฐ๋Š” ๋‹น์—ฐํ•œ ์ˆ˜์ •์ด๋ฏ€๋กœ, ์ฝ”๋ฉ˜ํŠธ ๋‚จ๊ธฐ์ง€ ์•Š์•„๋„ ๋ฉ๋‹ˆ๋‹ค.

@jhpark816
Copy link
Contributor

m4 ํŒŒ์ผ๋„ ์ˆ˜์ •ํ•ด์•ผ ํ•˜๋‚˜์š”?

@ing-eoking
Copy link
Collaborator Author

m4 ํŒŒ์ผ๋„ ์ˆ˜์ •ํ•ด์•ผ ํ•˜๋‚˜์š”?

git์—์„œ ๊ด€๋ฆฌํ•˜๋Š” ๋ชจ๋“  ํŒŒ์ผ์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

This was referenced Jan 23, 2025
Merged
Open
@ing-eoking ing-eoking marked this pull request as draft January 24, 2025 00:59
This was referenced Jan 24, 2025
Merged
Merged
Merged
Merged
@ing-eoking
Copy link
Collaborator Author

PR์ด ๋ชจ๋‘ ๋ถ„๋ฆฌ๋˜์—ˆ์œผ๋ฏ€๋กœ ํ•ด๋‹น PR์€ ๋‹ซ๊ฒ ์Šต๋‹ˆ๋‹ค.

@ing-eoking ing-eoking closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpark816 jhpark816 jhpark816 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ing-eoking @jhpark816