INTERNAL: Remove dummy fetch in the get API

naver · Jan 6, 2025 · a31b8bd · a31b8bd
1 parent e31c51b
commit a31b8bd
Showing 1 changed file with 27 additions and 24 deletions.
diff --git a/libmemcached/get.cc b/libmemcached/get.cc
@@ -494,6 +494,12 @@ char *memcached_get_by_key(memcached_st *ptr,
 {
   arcus_server_check_for_update(ptr);
 
+  if (value_length)
+    *value_length= 0;
+
+  if (flags)
+    *flags= 0;
+
   memcached_return_t unused;
   if (error == NULL)
     error= &unused;
@@ -512,11 +518,6 @@ char *memcached_get_by_key(memcached_st *ptr,
       *error= memcached_last_error(ptr);
     }
 
-    if (value_length)
-    {
-      *value_length= 0;
-    }
-
     return NULL;
   }
 
@@ -549,20 +550,34 @@ char *memcached_get_by_key(memcached_st *ptr,
       *error= memcached_last_error(ptr);
     }
 
-    if (value_length)
-      *value_length= 0;
-
     return NULL;
   }
 
-  char *value= memcached_fetch(ptr, NULL, NULL,
-                               value_length, flags, error);
+  char *value= NULL;
+  bool success_occurred= false;
+  memcached_result_st *result= &ptr->result;
+
+  while (memcached_fetch_result(ptr, result, error) != NULL)
+  {
+    success_occurred= true;
+    value= memcached_string_take_value(&result->value);
+    if (value_length)
+      *value_length= memcached_string_length(&result->value);
+    if (flags)
+      *flags= result->item_flags;
+  }
+
   assert_msg(ptr->query_id >= query_id +1, "Programmer error, the query_id was not incremented.");
   //assert_msg(ptr->query_id == query_id +1, "Programmer error, the query_id was not incremented.");
 
-  /* This is for historical reasons */
-  if (*error == MEMCACHED_END)
+  if (success_occurred)
+  {
+    *error= MEMCACHED_SUCCESS;
+  }
+  else if (*error == MEMCACHED_END)
+  {
     *error= MEMCACHED_NOTFOUND;
+  }
 
   if (value == NULL)
   {
@@ -616,18 +631,6 @@ char *memcached_get_by_key(memcached_st *ptr,
     return NULL;
   }
 
-  size_t dummy_length;
-  uint32_t dummy_flags;
-  memcached_return_t dummy_error;
-
-  char *dummy_value= memcached_fetch(ptr, NULL, NULL,
-                                     &dummy_length, &dummy_flags,
-                                     &dummy_error);
-  assert_msg(dummy_value == 0, "memcached_fetch() returned additional values beyond the single get it expected");
-  assert_msg(dummy_length == 0, "memcached_fetch() returned additional values beyond the single get it expected");
-  assert_msg(ptr->query_id >= query_id +1, "Programmer error, the query_id was not incremented.");
-  //assert_msg(ptr->query_id == query_id +1, "Programmer error, the query_id was not incremented.");
-
   return value;
 }