Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi-Instrument Rotation Trading Example with Controller for Binance #1939

Closed
wants to merge 2 commits into from

Conversation

graceyangfan
Copy link
Contributor

Pull Request

This PR adds a new feature for Multi-Instrument Rotation Trading Example with Controller for Binance. The feature demonstrates how to manage multiple instruments and implement rotation strategies using the controller, extending the functionality of the project and providing users with a practical example for multi-instrument strategies. #1936
@@limx0 @cuberone Thank you very much for your help. Please provide some suggestions.

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested?

This feature has been tested with Binance Testnet using simulated market data for multiple instruments to ensure that the rotation strategy works as expected.

@limx0
Copy link
Collaborator

limx0 commented Sep 14, 2024

Hi @graceyangfan - this looks like a great example to add!

The only minor improvement I would suggest is leveraging the cache (instruments and market data) for calculating your stats, so that the example would also work for backtesting purposes. But I think this can be added later.

@graceyangfan
Copy link
Contributor Author

@limx0 You're absolutely right. This is indeed a great step towards what we're aiming for. To achieve consistency between live trading and backtesting in Nautilus, a few minor internal adjustments are still needed.

@graceyangfan
Copy link
Contributor Author

In long-duration testing, it was discovered that there is still an issue with the code terminating automatically, without any obvious information. I need some time to troubleshoot and eliminate the bug.

@cjdsellers
Copy link
Member

Hey @graceyangfan

Thanks for the contribution here!

In terms of CI, it looks like there's just some pre-commit issues.

You can run pre-commit locally with either:

make pre-commit

or

pre-commit run --all-files

It's also possible to install a git hook so that pre-commit runs automatically on every commit:

pre-commit install

Let me know if you need any further help 🙏.

@graceyangfan
Copy link
Contributor Author

@cjdsellers The current submitted version still has some issues, and I haven't had the time to thoroughly review it recently. If possible, I can close this pull request for now.

@graceyangfan graceyangfan deleted the update1 branch September 26, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants