Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal fix for the bug that leads to endless loop at the end of day when downloading tick-level historical data from Interactive Brokers. #1652

Closed
wants to merge 3 commits into from

Conversation

DracheShiki
Copy link
Contributor

@DracheShiki DracheShiki commented May 19, 2024

Pull Request

Temporal fix for the bug that leads to endless loop at the end of day when downloading tick-level historical data from Interactive Brokers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested?

    if min_timestamp.floor("S") == max_timestamp.floor("S"):
        max_timestamp = max_timestamp.floor("S") + pd.Timedelta(seconds=1)

the original related code here only works in the following situation:
nt bug 1
but doesn't work in the following situation:
nt bug 2

Temporal fix. There must be better way than mine...

Temporal fix for the bug that leads to endless loop at end of day when downloading tick-level historical data from Interactive Brokers.
Adding pre-commit action so that pre-commit on github possible.
No need to pre-commit on local maschine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant