Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IB documentation and misc enhancements / bug fixes #1336

Merged
merged 8 commits into from
Nov 11, 2023
Merged

Update IB documentation and misc enhancements / bug fixes #1336

merged 8 commits into from
Nov 11, 2023

Conversation

benjaminsingleton
Copy link
Contributor

@benjaminsingleton benjaminsingleton commented Nov 11, 2023 •
edited
Loading

Pull Request

  • Rewrote all of the Interactive Brokers adapter documentation. I wrote the docs the way I wish they had been written when I first started exploring NT. Hope others find it helpful.
  • Updated docker image for IB Gateway and other fixes. Existing image has been abandoned for 6+ months and couldn't get it working.
  • Added host and port to InteractiveBrokersGatewayConfig
  • Added contract_details_to_ib_contract_details helper function
  • Other minor enhancements and bug/documentation fixes

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested?

  • Test InteractiveBrokersGateway works properly

@cjdsellers cjdsellers requested review from limx0 and rsmb7z November 11, 2023 05:34
@cjdsellers
Copy link
Member

Hey @benjaminsingleton

Thanks so much! I'll wait until you mark this as ready for review before merging 🙏

@benjaminsingleton benjaminsingleton marked this pull request as ready for review November 11, 2023 19:15
@cjdsellers cjdsellers removed the request for review from limx0 November 11, 2023 21:25
@cjdsellers
Copy link
Member

Thanks for the review @rsmb7z will merge now! 👏

@cjdsellers cjdsellers merged commit cbaf478 into nautechsystems:develop Nov 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsmb7z rsmb7z rsmb7z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjaminsingleton @cjdsellers @rsmb7z