Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HistoricInteractiveBrokersClient #1328

Merged
merged 13 commits into from
Nov 10, 2023

Conversation

benjaminsingleton
Copy link
Contributor

@benjaminsingleton benjaminsingleton commented Nov 7, 2023

Pull Request

Branched off @limx0's #1309

Establishes a HistoricInteractiveBrokersClient with convenience methods to retrieve instruments, bars, trade ticks, and quote ticks.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this change been tested?

TODO

@cjdsellers
Copy link
Member

Hey @benjaminsingleton

You could also try running the pre-commit.

make pre-commit

or

pre-commit run --all-files

This might fix the CI fails, hope that helps!
https://github.com/nautechsystems/nautilus_trader/blob/master/CONTRIBUTING.md

@limx0 limx0 mentioned this pull request Nov 9, 2023
@limx0
Copy link
Collaborator

limx0 commented Nov 9, 2023

@cjdsellers theres a clash between ruff and black on those long imports - had a quick go at trying to fix it but no luck

@cjdsellers
Copy link
Member

On mobile, try fmt: off above the imports then fmt: on under them

@benjaminsingleton benjaminsingleton changed the title WIP Ib historic WIP Create HistoricInteractiveBrokersClient Nov 10, 2023
@cjdsellers cjdsellers changed the title WIP Create HistoricInteractiveBrokersClient Add Create HistoricInteractiveBrokersClient Nov 10, 2023
@cjdsellers cjdsellers changed the title Add Create HistoricInteractiveBrokersClient Add HistoricInteractiveBrokersClient Nov 10, 2023
@cjdsellers cjdsellers marked this pull request as ready for review November 10, 2023 20:23
@cjdsellers cjdsellers merged commit b5c6505 into nautechsystems:develop Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants