-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HistoricInteractiveBrokersClient #1328
Merged
cjdsellers
merged 13 commits into
nautechsystems:develop
from
benjaminsingleton:ib_historic_bfs
Nov 10, 2023
Merged
Add HistoricInteractiveBrokersClient #1328
cjdsellers
merged 13 commits into
nautechsystems:develop
from
benjaminsingleton:ib_historic_bfs
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You could also try running the pre-commit.
or
This might fix the CI fails, hope that helps! |
Closed
@cjdsellers theres a clash between ruff and black on those long imports - had a quick go at trying to fix it but no luck |
On mobile, try |
benjaminsingleton
changed the title
WIP Ib historic
WIP Create HistoricInteractiveBrokersClient
Nov 10, 2023
limx0
approved these changes
Nov 10, 2023
cjdsellers
changed the title
WIP Create HistoricInteractiveBrokersClient
Add Create HistoricInteractiveBrokersClient
Nov 10, 2023
cjdsellers
changed the title
Add Create HistoricInteractiveBrokersClient
Add HistoricInteractiveBrokersClient
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Branched off @limx0's #1309
Establishes a
HistoricInteractiveBrokersClient
with convenience methods to retrieve instruments, bars, trade ticks, and quote ticks.Type of change
How has this change been tested?
TODO