Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data config: validate that the end time is set after the start time #1311

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

davidsblom
Copy link
Collaborator

Pull Request

Validate that the end time is a timestamp larger than the start time when configuring a backtest with the BacktestDataConfig.

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested?

This throws an ValueError when running the code snippet of #1304.

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2023

CLA assistant check
All committers have signed the CLA.

@davidsblom davidsblom changed the title data config: validate that the end time is set after the start time WIP: data config: validate that the end time is set after the start time Oct 28, 2023
@davidsblom davidsblom marked this pull request as draft October 28, 2023 06:53
@davidsblom davidsblom marked this pull request as ready for review October 28, 2023 07:04
@davidsblom davidsblom changed the title WIP: data config: validate that the end time is set after the start time data config: validate that the end time is set after the start time Oct 28, 2023
@cjdsellers cjdsellers merged commit 179728d into nautechsystems:develop Oct 28, 2023
6 checks passed
@davidsblom davidsblom deleted the validate_data_config branch October 29, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants