Passing Headers to WebSocketClient.connect()

[ruthvik125]

Pull Request

For issue #1236
-> Passing a hyper::Request to which headers can be inserted ,instead of a url ,in connect_async()

Type Of Change

• New feature (non-breaking change which adds functionality)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ cjdsellers
✅ ruthvik125
❌ ruthvik

---

ruthvik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ruthvik125]

We can use a hyper::Request to which we can insert headers and pass it in connect_async() to connect from the client. Is adding an extra parameter for headers: for every function that is calling connect() or connect_with_server() better , or is making a separate function for connecting with headers better?

[cjdsellers]

We can use a hyper::Request to which we can insert headers and pass it in connect_async() to connect from the client. Is adding an extra parameter for headers: for every function that is calling connect() or connect_with_server() better , or is making a separate function for connecting with headers better?

Hi @ruthvik125
Thanks for the contribution here!
I would say an additional parameter with a None like default would be the best way to go.

[twitu]

You'll need to take a Vec<(String, String)> because having lifetimes will be problematic in the Python API. And you want to store these headers in the WebsocketInnerClient so that they can be re-used in case of a reconnect.

[twitu]

You want to pass a clone of the stored Vec<(String, String)> here. Then consume and add the key value pairs to the request.

[cjdsellers]

We also need to run the pre-commit checks:

make pre-commit

or

pre-commit run --all-files

Many thanks!