Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix deleted recents issue #3989

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Attempt to fix deleted recents issue #3989

wants to merge 3 commits into from
+14 −12

Conversation

dbolack-ab
Copy link
Collaborator

@dbolack-ab dbolack-ab commented Jan 15, 2025 •
edited
Loading

Description

This attempts to prevent the deleted "Recently Viewed" listings by not adding them to the list if the relevant ID is falsey.

Related Issues or Discussions

Reviewer Checklist

Replace the list below with specific features you want reviewers to look at.

*Reviewers, refer to this list when testing features, or suggest new items *

  • Verify new features are functional
    • Create a new brew, save it, then delete it. Verify it does not show up on a reloaded Recents list
  • Verify old features have not broken
    • Make certain Recents are still properly populated.
  • Test for edge cases / try to break things

@dbolack-ab dbolack-ab self-assigned this Jan 15, 2025
@dbolack-ab dbolack-ab added tweak Small, non-breaking change 🔍 R0 - Needs first review 👀 PR ready but has not been reviewed labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dbolack-ab dbolack-ab

Labels
🔍 R0 - Needs first review 👀 PR ready but has not been reviewed tweak Small, non-breaking change
Projects
@calculuschild's backlog
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add function to update recent brews
3 participants
@dbolack-ab @calculuschild @dbolacksn